[REF] [Test] Minor simplification on test #18019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
event_clean
branch
2 times, most recently
from
fc48607 to
5e9656b
Compare
This is towards standardising on one way to reference created entities -ie ->ids['Participant'][key] = 4
eileenmcnaughton
force-pushed
the
event_clean
branch
from
5e9656b to
57a7aa8
Compare
|
@seamuslee001 can you merge this? |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor standardisation within test classes
Before
mix of ways to refer to created entities - both in terms of casing and property they are assigned to
After
Standardised
Technical Details
This is towards standardising on one way to reference created entities -ie
->ids['Participant'][key] = 4
Comments
Only affects tests